Messages in this thread | | | From | Bart Van Assche <> | Subject | Re: [PATCH] device_handler: remove VLAs | Date | Fri, 9 Mar 2018 22:48:10 +0000 |
| |
On Fri, 2018-03-09 at 23:32 +0100, Stephen Kitt wrote: > In preparation to enabling -Wvla, remove VLAs and replace them with > fixed-length arrays instead. > > scsi_dh_{alua,emc,rdac} use variable-length array declarations to > store command blocks, with the appropriate size as determined by > COMMAND_SIZE. This patch replaces these with fixed-sized arrays using > MAX_COMMAND_SIZE, so that the array size can be determined at compile > time.
If COMMAND_SIZE() is evaluated at compile time, do we still need this patch?
Thanks,
Bart.
| |