lkml.org 
[lkml]   [2018]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 07/36] drm/bridge: analogix_dp: Move enable video into config_video()
    Date
    From: Lin Huang <hl@rock-chips.com>

    We need to enable video before analogix_dp_is_video_stream_on(), so
    we can get the right video stream status.

    Cc: 征增 王 <wzz@rock-chips.com>
    Cc: Stéphane Marchesin <marcheu@chromium.org>
    Signed-off-by: Lin Huang <hl@rock-chips.com>
    Signed-off-by: Sean Paul <seanpaul@chromium.org>
    Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
    Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
    Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
    Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
    ---

    drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +++++------
    1 file changed, 5 insertions(+), 6 deletions(-)

    diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
    index 5a2e35dc41e3..f9661b410cb9 100644
    --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
    +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
    @@ -819,11 +819,10 @@ static int analogix_dp_config_video(struct analogix_dp_device *dp)
    if (analogix_dp_is_slave_video_stream_clock_on(dp) == 0)
    break;
    if (timeout_loop > DP_TIMEOUT_LOOP_COUNT) {
    - dev_err(dp->dev, "Timeout of video streamclk ok\n");
    + dev_err(dp->dev, "Timeout of slave video streamclk ok\n");
    return -ETIMEDOUT;
    }
    -
    - usleep_range(1, 2);
    + usleep_range(1000, 1001);
    }

    /* Set to use the register calculated M/N video */
    @@ -838,6 +837,9 @@ static int analogix_dp_config_video(struct analogix_dp_device *dp)
    /* Configure video slave mode */
    analogix_dp_enable_video_master(dp, 0);

    + /* Enable video */
    + analogix_dp_start_video(dp);
    +
    timeout_loop = 0;

    for (;;) {
    @@ -948,9 +950,6 @@ static void analogix_dp_commit(struct analogix_dp_device *dp)
    DRM_ERROR("failed to enable the panel\n");
    }

    - /* Enable video */
    - analogix_dp_start_video(dp);
    -
    dp->psr_enable = analogix_dp_detect_sink_psr(dp);
    if (dp->psr_enable)
    analogix_dp_enable_sink_psr(dp);
    --
    2.16.1
    \
     
     \ /
      Last update: 2018-03-09 23:33    [W:4.458 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site