lkml.org 
[lkml]   [2018]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH v2 01/17 1/3] mfd: abx500-core: Delete an error message for a failed memory allocation in abx500_register_ops()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 8 Mar 2018 11:44:33 +0100

    Omit an extra message for a memory allocation failure in this function.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    ---

    v2:
    Lee Jones requested a resend for this patch. The change was rebased
    on source files from Linux next-20180308.

    drivers/mfd/abx500-core.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/mfd/abx500-core.c b/drivers/mfd/abx500-core.c
    index 0d3846a4767c..c8c9d41abcaa 100644
    --- a/drivers/mfd/abx500-core.c
    +++ b/drivers/mfd/abx500-core.c
    @@ -40,10 +40,9 @@ int abx500_register_ops(struct device *dev, struct abx500_ops *ops)
    dev_entry = devm_kzalloc(dev,
    sizeof(struct abx500_device_entry),
    GFP_KERNEL);
    - if (!dev_entry) {
    - dev_err(dev, "register_ops kzalloc failed");
    + if (!dev_entry)
    return -ENOMEM;
    - }
    +
    dev_entry->dev = dev;
    memcpy(&dev_entry->ops, ops, sizeof(struct abx500_ops));

    --
    2.16.2
    \
     
     \ /
      Last update: 2018-03-09 17:03    [W:4.199 / U:1.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site