lkml.org 
[lkml]   [2018]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage
From
Date


On 03/09/2018 05:23 AM, Andreas Christoforou wrote:
> The kernel would like to have all stack VLA usage removed.
>
> This is the correct patch.
>
> Signed-off-by: Andreas Christoforou <andreaschristofo@gmail.com>

This is a lazy changelog really.

'This is the correct patch' has no technical value.

What is VLA ? Sure, _now_ its pretty clear since we have floods of
these patches, but...

In one or two years, people reading it will not understand the logic of
this patch.

I had to look at the source to understand what was going on, and that is
not a good sign for a trivial patch like that.

\
 
 \ /
  Last update: 2018-03-09 14:35    [W:0.081 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site