Messages in this thread Patch in this message | | | Date | Fri, 9 Mar 2018 01:16:28 -0800 | From | tip-bot for Colin Ian King <> | Subject | [tip:efi/core] efi: Make const array 'apple' static |
| |
Commit-ID: f779ca740f25c8a6a72d951334f9efc3158a318b Gitweb: https://git.kernel.org/tip/f779ca740f25c8a6a72d951334f9efc3158a318b Author: Colin Ian King <colin.king@canonical.com> AuthorDate: Thu, 8 Mar 2018 08:00:20 +0000 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Fri, 9 Mar 2018 09:30:35 +0100
efi: Make const array 'apple' static
Don't populate the const read-only array 'buf' on the stack but instead make it static. Makes the object code smaller by 64 bytes:
Before: text data bss dec hex filename 9264 1 16 9281 2441 arch/x86/boot/compressed/eboot.o
After: text data bss dec hex filename 9200 1 16 9217 2401 arch/x86/boot/compressed/eboot.o
(GCC version 7.2.0 x86_64)
Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20180308080020.22828-13-ard.biesheuvel@linaro.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/boot/compressed/eboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index 886a9115af62..f2251c1c9853 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b/arch/x86/boot/compressed/eboot.c @@ -423,7 +423,7 @@ static void retrieve_apple_device_properties(struct boot_params *boot_params) static void setup_quirks(struct boot_params *boot_params) { - efi_char16_t const apple[] = { 'A', 'p', 'p', 'l', 'e', 0 }; + static efi_char16_t const apple[] = { 'A', 'p', 'p', 'l', 'e', 0 }; efi_char16_t *fw_vendor = (efi_char16_t *)(unsigned long) efi_table_attr(efi_system_table, fw_vendor, sys_table);
| |