Messages in this thread | | | From | "Prakhya, Sai Praneeth" <> | Subject | RE: [PATCH 07/12] efi: Use efi_mm in x86 as well as ARM | Date | Fri, 9 Mar 2018 08:37:00 +0000 |
| |
> > diff --git a/include/linux/efi.h b/include/linux/efi.h index > > f5083aa72eae..f1b7d68ac460 100644 > > --- a/include/linux/efi.h > > +++ b/include/linux/efi.h > > @@ -966,6 +966,8 @@ extern struct efi { > > unsigned long flags; > > } efi; > > > > +extern struct mm_struct efi_mm; > > + > > static inline int > > efi_guidcmp (efi_guid_t left, efi_guid_t right) { > > Ugh, I can see three problems with this patch: > > 1) > > Why is the low level asm/efi.h header polluted with two of the biggest header > files in existence, to add a type to _another_ header (efi.h)? > > 2) > > Why is <linux/sched/task.h> included if what is being relied on is mm_struct? > > 3) > > But even <linux/sched/mm.h> looks unnecessary in efi.h, a simple forward > declaration of mm_struct would do ... > > The high level MM and sched headers should be added to the actual .c files that > make use of them.
Ok, makes sense. Sorry! for that. I will fix the issues.
Regards, Sai
| |