lkml.org 
[lkml]   [2018]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] of: unittest: remove unneeded local return value variables
On Thu, Mar 08, 2018 at 02:39:04PM -0800, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> A common pattern in many unittest functions is to save the return
> value of a function in a local variable, then test the value of
> the local variable, without using that return value for any further
> purpose. Remove the local return value variable for these cases.
>
> A second common pattern is:
>
> ret = some_test_function(many, parameters, ...);
> if (unittest(ret == 0, "error message format", ...))
> return;
>
> This pattern is more clear when the local variable 'ret' is used, due
> to the long lines caused by the parameters to the test function and
> the long format and data parameters of unittest(). The local
> variable is retained in these cases.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/of/unittest.c | 89 ++++++++++++++-------------------------------------
> 1 file changed, 24 insertions(+), 65 deletions(-)

Doesn't apply. What's it based on?

Rob

\
 
 \ /
  Last update: 2018-03-10 01:03    [W:0.062 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site