Messages in this thread | | | Date | Fri, 9 Mar 2018 18:52:23 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH v4 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE |
| |
On Fri, 9 Mar 2018 16:25:36 -0700 Lina Iyer <ilina@codeaurora.org> wrote:
> Log sent RPMH requests and interrupt responses in FTRACE. > > Cc: Steven Rostedt <rostedt@goodmis.org> > Signed-off-by: Lina Iyer <ilina@codeaurora.org> > --- > > Changes in v4: > - fix compilation issues, use __assign_str > - use %#x instead of 0x%08x
Hmm, I don't believe libtraceevent (used by trace-cmd and perf) supports "%#x". But that needs to be fixed in libtraceevent and you don't need to modify this patch.
+ __field(bool, wait)
Usually I would recommend against 'bool' in structures, but it shouldn't affect the tracing code. Might want to look at how it converts it in the /sys/kernel/tracing/events/rpmh/rpmh_send_msg/format file. It probably makes no difference if it was an int.
Other than that... Looks good.
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> Changes in v3: > - Use __string() instead of char * > - fix TRACE_INCLUDE_PATH > ---
| |