[lkml]   [2018]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v10 00/10] livepatch: Atomic replace feature
On 03/08/2018 10:01 AM, Petr Mladek wrote:
> On Wed 2018-03-07 16:55:53, Joe Lawrence wrote:
>> Running against v10, callbacks seem to be good up until I disable an
>> atomic replace patch. My understanding is that the original patch's
>> unpatch callbacks should be skipped (as they were). I was surprised to
>> see that atomic replacement patch only ran it's post-unpatch callback.
> Great catch!
> I guess that it is caused by the heuristic used in
> klp_unpatch_object() to decide whether the object is patched
> or not.
> We need to change the state only when manipulating the
> statically defined functions.
> Thanks a lot for so extensive testing!!!

Sorry for not getting to this series sooner. I'm trying to refit these
tests into a kselftest so we can more easily reuse them. Still hacking
away at it, but I'll post when something soon to start a livepatch
selftests conversation :)

-- Joe

 \ /
  Last update: 2018-03-08 16:10    [W:0.094 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site