Messages in this thread Patch in this message | | | From | Arvind Yadav <> | Subject | [PATCH 2/2] rpmsg: smd: use put_device() if device_register fail | Date | Thu, 8 Mar 2018 15:06:08 +0530 |
| |
if device_register() returned an error! Always use put_device() to give up the reference initialized. unregister device for other return error.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/rpmsg/qcom_smd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 92d0c6a..ff8101a 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -1408,6 +1408,7 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent, ret = device_register(&edge->dev); if (ret) { pr_err("failed to register smd edge\n"); + put_device(&edge->dev); return ERR_PTR(ret); } @@ -1428,7 +1429,7 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent, return edge; unregister_dev: - put_device(&edge->dev); + device_unregister(&edge->dev); return ERR_PTR(ret); } EXPORT_SYMBOL(qcom_smd_register_edge); -- 1.9.1
| |