Messages in this thread | | | Date | Thu, 8 Mar 2018 08:41:15 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 5/6] dma-mapping: support fsl-mc bus |
| |
On Tue, Mar 06, 2018 at 04:41:56AM +0000, Nipun Gupta wrote: > Sorry for asking a trivial question - looking into dma_configure() I see that > PCI is used in the start and the end of the API. > In the end part pci_put_host_bridge_device() is called. > So are two bus callbacks something like 'dma_config_start' & 'dma_config_end' > will be required where the former one will return "dma_dev"?
I'd just use dma_configure as the callback.
Currently the of_dma_configure and acpi_dma_configure are only used for PCI anyway, as no one else sets a non-NULL dma dev. For fsl-mc I suspect only of_dma_configure is relevanet, so just call that directly. If at some point we get enough busses with either OF or ACPI we could create a helper called from ->dma_configure for that.
| |