Messages in this thread | | | Date | Thu, 8 Mar 2018 13:06:33 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 0/3] Remove accidental VLA usage |
| |
On Thu, 8 Mar 2018 09:02:36 -0600 Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> On Wed, Mar 07, 2018 at 07:30:44PM -0800, Kees Cook wrote: > > This series adds SIMPLE_MAX() to be used in places where a stack array > > is actually fixed, but the compiler still warns about VLA usage due to > > confusion caused by the safety checks in the max() macro. > > > > I'm sending these via -mm since that's where I've introduced SIMPLE_MAX(), > > and they should all have no operational differences. > > What if we instead simplify the max() macro's type checking so that GCC > can more easily fold the array size constants? The below patch seems to > work:
Nice. Have you tried to do a allmodconfig and build on various archs?
Of course pushing it to kernel.org will have the zero day bot do it for you ;-)
-- Steve
| |