Messages in this thread | | | Date | Thu, 8 Mar 2018 09:07:36 -0800 | From | Tony Lindgren <> | Subject | Re: [PATCHv5 3/5] mfd: motorola-cpcap: Add audio-codec support |
| |
* Sebastian Reichel <sebastian.reichel@collabora.co.uk> [180308 09:47]: > Hi Lee, > > On Wed, Mar 07, 2018 at 04:32:11PM +0000, Lee Jones wrote: > > On Fri, 23 Feb 2018, Sebastian Reichel wrote: > > > +static const struct mfd_cell cpcap_mfd_devices[] = { > > [...] > > > > + }, { > > > + .name = "cpcap-led", > > > + .id = 4, > > > + .of_compatible = "motorola,cpcap-led-cp", > > > + }, { > > > + .name = "cpcap-codec", > > > + } > > > +}; > > > > With none of the entries containing platform_data /me wonders why you > > can't still use devm_of_platform_populate()? > > Because devm_of_platform_populate works with compatible properties and > cpcap-codec does not have one after I removed it for Mark.
How about keep devm_of_platform_populate() for the ones that already have compatible. Then add a table entry for cpcap-codec only and call devm_mfd_add_devices()?
Regards,
Tony
| |