lkml.org 
[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 053/110] rxrpc: Fix send in rxrpc_send_data_packet()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Howells <dhowells@redhat.com>


    [ Upstream commit 93c62c45ed5fad1b87e3a45835b251cd68de9c46 ]

    All the kernel_sendmsg() calls in rxrpc_send_data_packet() need to send
    both parts of the iov[] buffer, but one of them does not. Fix it so that
    it does.

    Without this, short IPv6 rxrpc DATA packets may be seen that have the rxrpc
    header included, but no payload.

    Fixes: 5a924b8951f8 ("rxrpc: Don't store the rxrpc header in the Tx queue sk_buffs")
    Reported-by: Marc Dionne <marc.dionne@auristor.com>
    Signed-off-by: David Howells <dhowells@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/rxrpc/output.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/rxrpc/output.c
    +++ b/net/rxrpc/output.c
    @@ -395,7 +395,7 @@ send_fragmentable:
    (char *)&opt, sizeof(opt));
    if (ret == 0) {
    ret = kernel_sendmsg(conn->params.local->socket, &msg,
    - iov, 1, iov[0].iov_len);
    + iov, 2, len);

    opt = IPV6_PMTUDISC_DO;
    kernel_setsockopt(conn->params.local->socket,

    \
     
     \ /
      Last update: 2018-03-07 20:48    [W:4.029 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site