Messages in this thread | | | Date | Wed, 7 Mar 2018 16:05:43 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events |
| |
Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu: > > > Sorry about that. That's probably because FNM_EXTMATCH is a GNU extension, > > > not POSIX, and the Alpine and Android runtimes likely don't implement > > > that... > > > I'll send a fix reverting back to the strncmp to ignore the uncore_ prefix, > > > and dropping that extension. > > > > Just don't set it? Even the basic glob patterns are useful. > > Or use: > > #ifndef FNM_EXTMATCH > #define FNM_EXTMATCH 0 > #endif > > So on systems without it, its not used, while on GNU systems, we have > that functionality (pretty fancy, someone may need that... ;-))
I'll try this route, btw, no need to send more patches for now.
- Arnaldo
| |