Messages in this thread | | | Subject | Re: [PATCH v4 1/2] dt-binding: timer: document NPCM7xx timer DT bindings | From | Daniel Lezcano <> | Date | Wed, 7 Mar 2018 18:25:47 +0100 |
| |
On 26/02/2018 15:36, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton NPCM7xx timer. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > Acked-by: Rob Herring <robh@kernel.org> > Reviewed-by: Brendan Higgins <brendanhiggins@google.com> > --- > .../bindings/timer/nuvoton,npcm7xx-timer.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt > > diff --git a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt > new file mode 100644 > index 000000000000..c5150522e618 > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt > @@ -0,0 +1,25 @@ > +Nuvoton NPCM7xx timer > + > +Nuvoton NPCM7xx have three timer modules, each timer module provides five 24-bit > +timer counters. > + > +Required properties: > +- compatible : "nuvoton,npcm750-timer" for Poleg NPCM750. > +- reg : Offset and length of the register set for the device. > +- interrupts : Contain the timer interrupt with flags for > + falling edge. > + > +Required clocking property, have to be one of: > +- clocks : phandle of timer reference clock. > +- clock-frequency : The frequency in Hz of the clock that drives the NPCM7xx > + timer (usually 25000000).
Why one of these and not the phandle only ? That will make the driver cleaner.
> + > +Example: > + > +timer@f0008000 { > + compatible = "nuvoton,npcm750-timer"; > + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; > + reg = <0xf0008000 0x1000>; > + clocks = <&clk NPCM7XX_CLK_TIMER>; > +}; > + >
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |