Messages in this thread | | | From | Bart Van Assche <> | Subject | Re: [PATCH 4/6] lib/scatterlist: Unexport some trivial wrappers | Date | Wed, 7 Mar 2018 16:19:01 +0000 |
| |
On Wed, 2018-03-07 at 12:47 +0000, Tvrtko Ursulin wrote: > Save some kernel size by moving trivial wrappers to header as static > inline instead of exporting symbols for them.
Something that you may be unaware of is that the introduction of the sgl helper functions is only a first step. The next step will be to introduce a caching allocator for sg-lists. So for small sg-lists inlining won't help performance. But moving these definitions from a .c file into a .h file will (slightly) slow down kernel compilation. So I'd prefer that you drop this patch.
Thanks,
Bart.
| |