Messages in this thread | | | From | Fabio Estevam <> | Date | Wed, 7 Mar 2018 11:24:10 -0300 | Subject | Re: [PATCH v3 1/2] mfd: arizona: Update reset pin to use GPIOD |
| |
Hi Charles,
On Tue, Feb 20, 2018 at 1:35 PM, Charles Keepax <ckeepax@opensource.cirrus.com> wrote:
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 77875250abe5..9558c4d9c8ca 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -279,7 +279,7 @@ static int arizona_wait_for_boot(struct arizona *arizona) > static inline void arizona_enable_reset(struct arizona *arizona) > { > if (arizona->pdata.reset) > - gpio_set_value_cansleep(arizona->pdata.reset, 0); > + gpiod_set_value_cansleep(arizona->pdata.reset, 0);
This should be:
gpiod_set_value_cansleep(arizona->pdata.reset, 1);
as here you want to put the reset GPIO into its active state.
Assuming that in the dts this GPIO is defined as GPIO_ACTIVE_LOW, then the command should put it to logic level 0 as done originally.
> static void arizona_disable_reset(struct arizona *arizona) > @@ -295,7 +295,7 @@ static void arizona_disable_reset(struct arizona *arizona) > break; > } > > - gpio_set_value_cansleep(arizona->pdata.reset, 1); > + gpiod_set_value_cansleep(arizona->pdata.reset, 1);
This should be:
gpiod_set_value_cansleep(arizona->pdata.reset, 0);
as here you want to put the reset GPIO into its inactive state.
| |