Messages in this thread | | | Date | Wed, 7 Mar 2018 11:52:16 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [Outreachy kernel] Re: [PATCH v3] staging: rtl8192u: Replace printk() with more standardize output format. |
| |
On Wed, 7 Mar 2018, Dan Carpenter wrote:
> On Wed, Mar 07, 2018 at 04:09:09PM +0530, Arushi Singhal wrote: > > @@ -276,22 +276,22 @@ static int ieee80211_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv) > > keyidx = pos[3]; > > if (!(keyidx & (1 << 5))) { > > if (net_ratelimit()) { > > - printk(KERN_DEBUG "CCMP: received packet without ExtIV flag from %pM\n", > > - hdr->addr2); > > + netdev_dbg(skb->dev, "CCMP: received packet without ExtIV flag from %pM\n", > > + hdr->addr2); > > } > > I'm sorry. I really hate to do this to you... But the right thing here > is to use net_dbg_ratelimited() but get rid of the if (net_ratelimit()) > check. So it looks like this: > > if (!(keyidx & (1 << 5))) { > net_dbg_ratelimited(skb->dev, > "CCMP: received packet without ExtIV flag from %pM\n", > hdr->addr2); > } > > Sorry again, when I looked at it before I just replied what my fast > thinking lizard brain said instead of taking time to look at what I was > saying.
I don't think that net_dbg_ratelimited wants a skb->dev argument. The various definitions in include/linux/net.h just have fmt as the first argument.
julia
> > > regards, > dan carpenter > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180307104741.mdy2wa7hplfwxmb3%40mwanda. > For more options, visit https://groups.google.com/d/optout. >
| |