lkml.org 
[lkml]   [2018]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.15 61/78] pinctrl: rockchip: enable clock when reading pin direction register
    Date
    From: Brian Norris <briannorris@chromium.org>

    [ Upstream commit 5c9d8c4f6b8168738a26bcf288516cc3a0886810 ]

    We generally leave the GPIO clock disabled, unless an interrupt is
    requested or we're accessing IO registers. We forgot to do this for the
    ->get_direction() callback, which means we can sometimes [1] get
    incorrect results [2] from, e.g., /sys/kernel/debug/gpio.

    Enable the clock, so we get the right results!

    [1] Sometimes, because many systems have 1 or mor interrupt requested on
    each GPIO bank, so they always leave their clock on.

    [2] Incorrect, meaning the register returns 0, and so we interpret that
    as "input".

    Signed-off-by: Brian Norris <briannorris@chromium.org>
    Reviewed-by: Heiko Stuebner <heiko@sntech.de>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/pinctrl/pinctrl-rockchip.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
    index 2ba17548ad5b..073de6a9ed34 100644
    --- a/drivers/pinctrl/pinctrl-rockchip.c
    +++ b/drivers/pinctrl/pinctrl-rockchip.c
    @@ -2014,8 +2014,16 @@ static int rockchip_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
    {
    struct rockchip_pin_bank *bank = gpiochip_get_data(chip);
    u32 data;
    + int ret;

    + ret = clk_enable(bank->clk);
    + if (ret < 0) {
    + dev_err(bank->drvdata->dev,
    + "failed to enable clock for bank %s\n", bank->name);
    + return ret;
    + }
    data = readl_relaxed(bank->reg_base + GPIO_SWPORT_DDR);
    + clk_disable(bank->clk);

    return !(data & BIT(offset));
    }
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-08 07:57    [W:2.210 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site