Messages in this thread | | | Date | Thu, 8 Mar 2018 00:39:12 +0100 | From | Frederic Weisbecker <> | Subject | Re: [RFC/RFT][PATCH v2 2/6] sched: idle: Do not stop the tick upfront in the idle loop |
| |
On Tue, Mar 06, 2018 at 10:02:15AM +0100, Rafael J. Wysocki wrote: > Index: linux-pm/kernel/sched/idle.c > =================================================================== > --- linux-pm.orig/kernel/sched/idle.c > +++ linux-pm/kernel/sched/idle.c > @@ -220,13 +220,17 @@ static void do_idle(void) > */ > > __current_set_polling(); > - tick_nohz_idle_enter(); > + tick_nohz_idle_prepare();
Since we leave tick_nohz_idle_exit() unchanged, can we keep tick_nohz_idle_prepare() under the name tick_nohz_idle_enter() so that we stay symetric? And then make xen call the two functions:
tick_nohz_idle_enter(); tick_nohz_idle_go_idle();
Also can we rename tick_nohz_idle_go_idle() to tick_nohz_idle_stop_tick() ? This will be more self-explanatory.
Thanks.
| |