lkml.org 
[lkml]   [2018]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf stat: fix cvs output format
> My understanding was that at some place there is a if/else
>
> if (supported counters)
> fprintf_something with N fields, all filled in
> else
> fprintf_empty_fields with != N fields
>
> So I think this is not about using things like 'a,b,,,,,,' but about
> using different number of commas (fields) for supported/unsupported
> counters, no?

I believe it's only about empty fields at the end. I don't think
we ever get the columns wrong.

The original patch just moved the problem because there are still
cases where we can output different number of columns.

If a tool looks only at the first row to allocate the number of columns
it might error out if there are lines with more columns later.

All outputs have to be padded to the maximum number of columns,
so removing columns is never the right fix.

-Andi

\
 
 \ /
  Last update: 2018-03-06 19:58    [W:0.081 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site