Messages in this thread | | | From | Logan Gunthorpe <> | Date | Tue, 6 Mar 2018 10:03:55 -0700 | Subject | Re: [PATCH v11 7/7] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header |
| |
On 06/03/18 04:57 AM, Andy Shevchenko wrote: > On Tue, Mar 6, 2018 at 1:46 PM, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: >> On Tue, Mar 06, 2018 at 12:48:29PM +0200, Andy Shevchenko wrote: >>> On Mon, Mar 5, 2018 at 9:08 PM, Logan Gunthorpe <logang@deltatee.com> wrote: >>>> Clean up the ifdefs which conditionally defined the io{read|write}64 >>>> functions in favour of the new common io-64-nonatomic-lo-hi header. >>> >>>> #include <linux/kthread.h> >>>> #include <linux/interrupt.h> >>>> #include <linux/ntb.h> >>>> +#include <linux/io-64-nonatomic-lo-hi.h> >>> >>> A nit, can we preserve alphabetical ordering? >> >> Ugh, why, it doesn't matter at all :) > > I'm fine with either way, but ordering is a good thing to have in long > term prospective. > Easy to find what headers are in there, easy to understand if you need > another one or not, easy to maintain the list w/o duplications. > > I saw already few examples where long list of headers contained > duplications b/c it was in messy order. >
I agree with Greg here. This is a bit silly. The list isn't even alphabetical to begin with so it can't be preserved. However, if I do a v12 I'll make it alphabetical.
Logan
| |