Messages in this thread | | | Date | Tue, 6 Mar 2018 16:03:16 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH 1/1] HID: core: rewrite the hid-generic automatic unbind |
| |
On Tue, 6 Mar 2018, Benjamin Tissoires wrote:
> > We actually can have the unbind/rebind logic in hid-core.c, leaving > > only the match function in hid-generic. > > This makes hid-generic simpler and the whole logic simpler too. > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > --- > > > > Hi Jiri, > > > > while trying to find out a local bug, I figured out we don't really > > need the bus_add_driver and bus_removed_driver callbacks. > > > > This makes the code simpler and also allows other drivers to remove > > themself if other conditions are met. They just need to implement a smart > > enough .matchcallback and they are done. > > > > Looks like you are reviewing HID patches right now :)
Indeed! :)
> I just wanted to dig this one out from your mailbox. I still think > it's valuable. > IIRC it should still apply on your tree, but if not, I can quickly > update the patch.
Ah, thanks for a friendly ping! This really slipped in between cracks. Applied now.
-- Jiri Kosina SUSE Labs
| |