Messages in this thread | | | Subject | Re: [PATCH] pinctrl: intel: Implement intel_gpio_get_direction callback | From | Andy Shevchenko <> | Date | Tue, 06 Mar 2018 16:59:28 +0200 |
| |
On Tue, 2018-03-06 at 16:56 +0200, Andy Shevchenko wrote: > On Tue, 2018-03-06 at 14:31 +0000, Javier Arteaga wrote:
> > > +static int intel_gpio_get_direction(struct gpio_chip *chip, > > > unsigned int offset) > > > +{
> > > + if (padcfg0 & PADCFG0_PMODE_MASK) > > > + return -EINVAL; > > Actually we might return direction of GPIO function while pin is in > some > other mode, though it would probably make not much sense in practice.
One more though, this is a call back for GPIO function anyway, so, above condition should never happen. I think it's safe to remove it completely.
> > > + > > > + return !!(padcfg0 & PADCFG0_GPIOTXDIS); > > > +}
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |