lkml.org 
[lkml]   [2018]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/3] mfd: rave-sp: Convert print_hex_dump() to print_hex_dump_debug()
    From
    Date
    Am Montag, den 26.02.2018, 07:07 -0800 schrieb Andrey Smirnov:
    > Convert print_hex_dump() to print_hex_dump_debug() to be able to
    > leverage CONFIG_DYNAMIC_DEBUG.
    >
    > Cc: linux-kernel@vger.kernel.org
    > Cc: cphealy@gmail.com
    > Cc: Lucas Stach <l.stach@pengutronix.de>
    > Cc: Lee Jones <lee.jones@linaro.org>
    > Cc: Guenter Roeck <linux@roeck-us.net>
    > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>

    Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

    > ---
    >  drivers/mfd/rave-sp.c | 8 ++++----
    >  1 file changed, 4 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
    > index 9e4c83ff2aec..cec1e309b31f 100644
    > --- a/drivers/mfd/rave-sp.c
    > +++ b/drivers/mfd/rave-sp.c
    > @@ -311,8 +311,8 @@ static int rave_sp_write(struct rave_sp *sp,
    > const u8 *data, u8 data_size)
    >  
    >   length = dest - frame;
    >  
    > - print_hex_dump(KERN_DEBUG, "rave-sp tx: ", DUMP_PREFIX_NONE,
    > -        16, 1, frame, length, false);
    > + print_hex_dump_debug("rave-sp tx: ", DUMP_PREFIX_NONE,
    > +      16, 1, frame, length, false);
    >  
    >   return serdev_device_write(sp->serdev, frame, length, HZ);
    >  }
    > @@ -453,8 +453,8 @@ static void rave_sp_receive_frame(struct rave_sp
    > *sp,
    >   struct device *dev           = &sp->serdev->dev;
    >   u8 crc_calculated[checksum_length];
    >  
    > - print_hex_dump(KERN_DEBUG, "rave-sp rx: ", DUMP_PREFIX_NONE,
    > -        16, 1, data, length, false);
    > + print_hex_dump_debug("rave-sp rx: ", DUMP_PREFIX_NONE,
    > +      16, 1, data, length, false);
    >  
    >   if (unlikely(length <= checksum_length)) {
    >   dev_warn(dev, "Dropping short frame\n");

    \
     
     \ /
      Last update: 2018-03-06 15:10    [W:2.220 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site