lkml.org 
[lkml]   [2018]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: powerpc: Keep const vars out of writable .sdata
Date
On Thu, 2018-03-01 at 01:02:49 UTC, Kees Cook wrote:
> From: Segher Boessenkool <segher@kernel.crashing.org>
>
> Newer gcc will support "-mno-readonly-in-sdata"[1], which makes sure that
> the optimization on PPC32 for variables getting moved into the .sdata
> section will not apply to const variables (which must be in .rodata).
>
> This was originally noticed in mm/rodata_test.c when rodata_test_data
> was not static:
>
> c0695034 g O .data 00000004 rodata_test_data
>
> After this patch with an updated compiler, this is correctly in .rodata.
>
> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82411
>
> Reported-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
> Signed-off-by: Kees Cook <keescook@chromium.org>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/51d42f0f5fd6c74144d19bf6a66352

cheers

\
 
 \ /
  Last update: 2018-03-06 14:32    [W:0.097 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site