Messages in this thread | | | Date | Mon, 5 Mar 2018 22:35:50 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH 07/34] x86/entry/32: Restore segments before int registers |
| |
On Mon, Mar 05, 2018 at 12:50:33PM -0800, Linus Torvalds wrote: > On Mon, Mar 5, 2018 at 12:38 PM, Brian Gerst <brgerst@gmail.com> wrote: > > > > There already is a test: single_step_syscall.c > > Ahh, good. So presumably Joerg actually did check it, just didn't even notice ;)
Yeah, sort of. I ran the test, but it didn't catch the failure case in previous versions which was return to user with kernel-cr3 :)
I could probably add some debug instrumentation to check for that in my future testing, as there is no NX protection in the user address-range for the kernel-cr3.
Joerg
| |