Messages in this thread | | | Subject | Re: [PATCH v12 09/11] mm: Allow arch code to override copy_highpage() | From | Khalid Aziz <> | Date | Mon, 5 Mar 2018 13:42:25 -0700 |
| |
On 03/05/2018 12:24 PM, Dave Hansen wrote: > On 02/21/2018 09:15 AM, Khalid Aziz wrote: >> +#ifndef __HAVE_ARCH_COPY_HIGHPAGE >> + >> static inline void copy_highpage(struct page *to, struct page *from) >> { >> char *vfrom, *vto; >> @@ -248,4 +250,6 @@ static inline void copy_highpage(struct page *to, struct page *from) >> kunmap_atomic(vfrom); >> } >> >> +#endif > > I think we prefer that these are CONFIG_* options.
I added this mechanism to be same as what we have for copy_user_highpage():
--------------- #ifndef __HAVE_ARCH_COPY_USER_HIGHPAGE
static inline void copy_user_highpage(struct page *to, struct page *from, unsigned long vaddr, struct vm_area_struct *vma) { ----------------
There isn't a CONFIG_* option for copy_user_highpage() so I don't see a reason to add one for copy_highpage().
Do you see it differently? In that case, should there be a CONFIG_* option for copy_user_highpage() as well?
Thanks, Khalid
| |