lkml.org 
[lkml]   [2018]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] uprobe: add support for overlayfs
On Tue, Feb 27, 2018 at 04:40:14PM -0800, Howard McLauchlan wrote:
> uprobes cannot successfully attach to binaries located in a directory
> mounted with overlayfs.
>
> To verify, create directories for mounting overlayfs
> (upper,lower,work,merge), move some binary into merge/ and use readelf
> to obtain some known instruction of the binary. I used /bin/true and the
> entry instruction(0x13b0):
>
> $ mount -t overlay overlay -o lowerdir=lower,upperdir=upper,workdir=work merge
> $ cd /sys/kernel/debug/tracing
> $ echo 'p:true_entry PATH_TO_MERGE/merge/true:0x13b0' > uprobe_events
> $ echo 1 > events/uprobes/true_entry/enable
>
> This returns 'bash: echo: write error: Input/output error' and dmesg
> tells us 'event trace: Could not enable event true_entry'
>
> This change makes create_trace_uprobe() look for the real inode of a
> dentry. In the case of normal filesystems, this simplifies to just
> returning the inode. In the case of overlayfs(and similar fs) we will
> obtain the underlying dentry and corresponding inode, upon which uprobes
> can successfully register.
>
> Running the example above with the patch applied, we can see that the
> uprobe is enabled and will output to trace as expected.
>
> Signed-off-by: Howard McLauchlan <hmclauchlan@fb.com>

Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks,

Josef

\
 
 \ /
  Last update: 2018-03-05 20:59    [W:0.041 / U:1.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site