lkml.org 
[lkml]   [2018]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC/RFT][PATCH 1/7] time: tick-sched: Reorganize idle tick management code
    On Sun, Mar 04, 2018 at 11:24:00PM +0100, Rafael J. Wysocki wrote:
    > +/**
    > + * tick_nohz_idle_prepare - prepare for entering idle on the current CPU.
    > + *
    > + * Called when we start the idle loop.
    > + */
    > +void tick_nohz_idle_prepare(void)
    > +{
    > + __tick_nohz_idle_prepare();
    > +
    > + local_irq_enable();
    > +}

    I really dislike the asymmetry in IRQ state you introduced here.
    __tick_nohz_idle_prepare() disables IRQs. Must we do that?

    \
     
     \ /
      Last update: 2018-03-05 11:45    [W:8.016 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site