Messages in this thread | | | Subject | Re: [PATCH v2 2/2] ARM: ftrace: Add MODULE_PLTS support | From | Alexander Sverdlin <> | Date | Mon, 5 Mar 2018 10:18:56 +0100 |
| |
Hello Steven!
On 02/03/18 18:00, Steven Rostedt wrote: >> diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h >> index 9e842ff..3e663f9 100644 >> --- a/arch/arm/include/asm/ftrace.h >> +++ b/arch/arm/include/asm/ftrace.h >> @@ -19,6 +19,7 @@ struct dyn_arch_ftrace { >> #ifdef CONFIG_OLD_MCOUNT >> bool old_mcount; >> #endif > I think you want to add: > > #ifdef CONFIG_ARM_MODULE_PLTS >> + struct module *mod; > #endif > > This will add more memory overhead, and we don't want to add that if it > is not needed.
Will include it into the next version. Thanks for the review!
-- Best regards, Alexander Sverdlin.
| |