Messages in this thread | | | Subject | Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer | From | Jason Wang <> | Date | Mon, 5 Mar 2018 10:39:14 +0800 |
| |
On 2018年03月03日 00:07, Jesper Dangaard Brouer wrote: > On Fri, 2 Mar 2018 17:29:14 +0800 > Jason Wang <jasowang@redhat.com> wrote: > >> XDP_REDIRECT support for mergeable buffer was removed since commit >> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() >> case"). This is because we don't reserve enough tailroom for struct >> skb_shared_info which breaks XDP assumption. So this patch fixes this >> by reserving enough tailroom and using fixed size of rx buffer. >> >> Signed-off-by: Jason Wang <jasowang@redhat.com> >> --- >> Changes from V1: >> - do not add duplicated tracepoint when redirection fails > Acked-by: Jesper Dangaard Brouer <brouer@redhat.com> > > I gave it a quick spin on my testlab, and cpumap seems to > work/not-crash now (if I managed to turn back config to > receive_mergeable() correctly ;-)). >
Thanks for the testing and reviewing.
| |