lkml.org 
[lkml]   [2018]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [kbuild-all] [PATCH] nvmem: meson-efuse: fix ptr_ret.cocci warnings
    On Sun, Mar 4, 2018 at 2:56 PM, kbuild test robot <lkp@intel.com> wrote:
    > From: Fengguang Wu <fengguang.wu@intel.com>
    >
    > drivers/nvmem/meson-efuse.c:64:1-3: WARNING: PTR_ERR_OR_ZERO can be used
    >
    >
    > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
    >
    > Generated by: scripts/coccinelle/api/ptr_ret.cocci
    >
    > Fixes: 0d4f662ed6ff ("nvmem: meson-efuse: Do no gate COMPILE_TEST with MESON_SM")

    Original code was fine.

    This is more of a style preference, so I don't think it deserves a Fixes tag.

    > CC: Andrey Smirnov <andrew.smirnov@gmail.com>
    > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
    > ---
    >
    > meson-efuse.c | 5 +----
    > 1 file changed, 1 insertion(+), 4 deletions(-)
    >
    > --- a/drivers/nvmem/meson-efuse.c
    > +++ b/drivers/nvmem/meson-efuse.c
    > @@ -61,10 +61,7 @@ static int meson_efuse_probe(struct plat
    > econfig.size = size;
    >
    > nvmem = devm_nvmem_register(&pdev->dev, &econfig);
    > - if (IS_ERR(nvmem))
    > - return PTR_ERR(nvmem);
    > -
    > - return 0;
    > + return PTR_ERR_OR_ZERO(nvmem);
    > }
    >
    > static struct platform_driver meson_efuse_driver = {
    > _______________________________________________
    > kbuild-all mailing list
    > kbuild-all@lists.01.org
    > https://lists.01.org/mailman/listinfo/kbuild-all

    \
     
     \ /
      Last update: 2018-03-04 19:00    [W:14.745 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site