Messages in this thread | | | From | Ulf Magnusson <> | Date | Sun, 1 Apr 2018 04:40:25 +0200 | Subject | Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax |
| |
On Sun, Apr 1, 2018 at 4:27 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote: > > AFAICS, we only need the following functionality: > > 1. Record referenced environment variables along with their value > > 2. Go through all the recorded environment variables and write > dependency information > > For (1), I think it would be better to simply have env_list_add() (or > some other suitable name) add the variable to the list if it isn't > already there (like a kind of set). It is always safe to get the value > of the environment variable from getenv(), and that seems less > confusing. >
env_list_lookup() could be removed then as well.
Cheers, Ulf
| |