| Date | Sat, 31 Mar 2018 11:46:40 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2 71/75] staging: ks7010: Remove dummy address set. |
| |
On Fri, Mar 30, 2018 at 11:08:51PM -0700, Quytelda Kahja wrote: > Setting a dummy address during the driver probe is not necessary. > The dev_addr field is already zeroed out from alloc_etherdev(). > > Signed-off-by: Quytelda Kahja <quytelda@tamalin.org> > --- > drivers/staging/ks7010/ks_wlan_net.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c > index 5c5569000fce..afbc472baa05 100644 > --- a/drivers/staging/ks7010/ks_wlan_net.c > +++ b/drivers/staging/ks7010/ks_wlan_net.c > @@ -2852,9 +2852,6 @@ int ks_wlan_close(struct net_device *dev) > /* Operational parameters that usually are not changed. */ > /* Time in jiffies before concluding the transmitter is hung. */ > #define TX_TIMEOUT (3 * HZ) > -static const unsigned char dummy_addr[] = { > - 0x00, 0x0b, 0xe3, 0x00, 0x00, 0x00
Of course, this isn't a zero address. Do we know why they chose this particular address? I was expecting it to be zero from the patch description.
regards, dan carpenter
|