lkml.org 
[lkml]   [2018]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes.
On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote:
> On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote:
> > This macro, provided in 'linux/kernel.h', will calculate the size
> > more succinctly than a division operation.
>
> It's nice that you send patches, but please try to send a
> cover letter with your patch series.
>

There are obviously times when a cover letter is required but what's the
point of that for this particular series? What do you want the cover
letter to say here that isn't obvious to everyone just from glancing at
their inbox?

> Also, 75 patches is quite a lot for a staging patch series.
>
> Please try to send fewer patches in your series, say a
> maximum of 20 or so and see what happens to those patches
> before sending the next set.

Do we really care about that for staging? I can review the first 67
patches basically automatically so they take me about 5 seconds each. I
feel like splitting it up risks introducing more conflicts so it
actually makes the process harder/worse.

regards,
dan carpenter


\
 
 \ /
  Last update: 2018-03-31 10:43    [W:0.266 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site