lkml.org 
[lkml]   [2018]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/17] staging: lustre: ldlm: free resource when ldlm_lock_create() fails.

> ldlm_lock_create() gets a resource, but don't put it on
> all failure paths. It should.

Reviewed-by: James Simmons <jsimmons@infradead.org>

> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> index b8fd778d9832..614caa4a9b0e 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> @@ -1551,8 +1551,10 @@ struct ldlm_lock *ldlm_lock_create(struct ldlm_namespace *ns,
> return ERR_CAST(res);
>
> lock = ldlm_lock_new(res);
> - if (!lock)
> + if (!lock) {
> + ldlm_resource_putref(res);
> return ERR_PTR(-ENOMEM);
> + }
>
> lock->l_req_mode = mode;
> lock->l_ast_data = data;
> @@ -1595,6 +1597,8 @@ struct ldlm_lock *ldlm_lock_create(struct ldlm_namespace *ns,
> return ERR_PTR(rc);
> }
>
> +
> +
> /**
> * Enqueue (request) a lock.
> * On the client this is called from ldlm_cli_enqueue_fini
>
>
>

\
 
 \ /
  Last update: 2018-03-30 20:59    [W:0.173 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site