lkml.org 
[lkml]   [2018]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/17] staging: lustre: remove invariant in cl_io_read_ahead()

    > This invariant can fail as ci_type is somtimes CIS_INIT.
    >
    > According to Jinshan Xiong, or of the most recent significant
    > change to this code, "We should get rid of it."
    >
    > So do that.

    Reviewed-by: James Simmons <jsimmons@infradead.org>

    > Fixes: 1e1db2a97be5 ("staging: lustre: clio: Revise read ahead implementation")
    > Cc: Jinshan Xiong <jinshan.xiong@intel.com>
    > Signed-off-by: NeilBrown <neilb@suse.com>
    > ---
    > drivers/staging/lustre/lustre/obdclass/cl_io.c | 1 -
    > 1 file changed, 1 deletion(-)
    >
    > diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
    > index ab84e011b560..fcdae6029258 100644
    > --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
    > +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
    > @@ -599,7 +599,6 @@ int cl_io_read_ahead(const struct lu_env *env, struct cl_io *io,
    > int result = 0;
    >
    > LINVRNT(io->ci_type == CIT_READ || io->ci_type == CIT_FAULT);
    > - LINVRNT(io->ci_state == CIS_IO_GOING || io->ci_state == CIS_LOCKED);
    > LINVRNT(cl_io_invariant(io));
    >
    > cl_io_for_each(scan, io) {
    >
    >
    >

    \
     
     \ /
      Last update: 2018-03-30 20:57    [W:2.693 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site