lkml.org 
[lkml]   [2018]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang.
On Fri, Mar 30, 2018 at 02:03:38PM +0200, Frans Meulenbroeks wrote:
> mdio-bitbang mentioned 10 for both read and write.
> However mdio read opcode is 10 and write opcode is 01
> Fixed comment.
>
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>

Hi Frans

The correct place to send this patch is <netdev@vger.kernel.org> and
David Miller <davem@davemloft.net>. Please can you submit it again, to
these addresses.

In general, if you don't know where to send a patch,
scripts/get_maintainers.pl will tell you.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Andrew


> ---
> drivers/net/phy/mdio-bitbang.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c
> index 61a543c..403b085 100644
> --- a/drivers/net/phy/mdio-bitbang.c
> +++ b/drivers/net/phy/mdio-bitbang.c
> @@ -113,7 +113,7 @@ static void mdiobb_cmd(struct mdiobb_ctrl *ctrl, int
> op, u8 phy, u8 reg)
> for (i = 0; i < 32; i++)
> mdiobb_send_bit(ctrl, 1);
>
> - /* send the start bit (01) and the read opcode (10) or write (10).
> + /* send the start bit (01) and the read opcode (10) or write (01).
> Clause 45 operation uses 00 for the start and 11, 10 for
> read/write */
> mdiobb_send_bit(ctrl, 0);
> --
> 2.7.4


\
 
 \ /
  Last update: 2018-03-30 16:14    [W:0.033 / U:1.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site