lkml.org 
[lkml]   [2018]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 12/76] staging: ks7010: Remove trailing _t from 'struct hostif_mib_set_confirm_t'.
    On Fri, Mar 30, 2018 at 12:07:35AM -0700, Quytelda Kahja wrote:
    > The "_t" suffix is not needed for structure names in this driver, and is a
    > reflection of an older typedef system that is no longer in place. Replace
    > all occurences of 'struct hostif_mib_set_confirm_t' with 'struct
    > hostif_mib_set_confirm'.
    >
    > Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
    > ---
    > drivers/staging/ks7010/ks_hostif.h | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
    > index 5261810fbc76..7a0e0c610c50 100644
    > --- a/drivers/staging/ks7010/ks_hostif.h
    > +++ b/drivers/staging/ks7010/ks_hostif.h
    > @@ -175,7 +175,7 @@ struct hostif_mib_set_request {
    > struct hostif_mib_value mib_value;
    > } __packed;
    >
    > -struct hostif_mib_set_confirm_t {
    > +struct hostif_mib_set_confirm {
    > struct hostif_hdr header;
    > __le32 mib_status;
    > __le32 mib_attribute;

    As Joe points out, please just remove structures that are not used at
    all, it's pointless to keep them around.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2018-03-30 12:02    [W:4.020 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site