lkml.org 
[lkml]   [2018]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/9] staging: ks7010: Replace manual array copy with ether_addr_copy().
From
Date
On Thu, 2018-03-29 at 23:03 -0700, Quytelda Kahja wrote:
> If we just want to have the address field full of zeros during the
> driver probe, is there a reason we should zero it explicitly here?
> When the 'struct net_device' is first allocated using
> alloc_etherdev(), the dev_addr field is explicitly set to zeros (in
> the subfunction dev_addr_init() in net/core/dev_addr_lists.c), so it
> should be zeroed already at this point in the code.

You didn't describe the removal in your commit message
so it looked unintentional.

You should describe _why_ it's OK to remove it in that
commit message.

\
 
 \ /
  Last update: 2018-03-30 08:06    [W:0.110 / U:19.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site