lkml.org 
[lkml]   [2018]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.14 78/84] Fix misannotated out-of-line _copy_to_user()
    Date
    From: Christophe Leroy <christophe.leroy@c-s.fr>

    [ Upstream commit a0e94598e6b6c0d1df6a5fa14eb7c767ca817a20 ]

    Destination is a kernel pointer and source - a userland one
    in _copy_from_user(); _copy_to_user() is the other way round.

    Fixes: d597580d37377 ("generic ...copy_..._user primitives")
    Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    lib/usercopy.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/lib/usercopy.c b/lib/usercopy.c
    index 15e2e6fb060e..3744b2a8e591 100644
    --- a/lib/usercopy.c
    +++ b/lib/usercopy.c
    @@ -20,7 +20,7 @@ EXPORT_SYMBOL(_copy_from_user);
    #endif

    #ifndef INLINE_COPY_TO_USER
    -unsigned long _copy_to_user(void *to, const void __user *from, unsigned long n)
    +unsigned long _copy_to_user(void __user *to, const void *from, unsigned long n)
    {
    might_fault();
    if (likely(access_ok(VERIFY_WRITE, to, n))) {
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-04 01:12    [W:5.248 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site