lkml.org 
[lkml]   [2018]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 129/219] drm/amdgpu: Fail fb creation from imported dma-bufs. (v2)
    Date
    From: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>

    [ Upstream commit 1769152ac64b0b07583f696b621624df2ca4c840 ]

    Any use of the framebuffer will migrate it to VRAM, which is not sensible for
    an imported dma-buf.

    v2: Use DRM_DEBUG_KMS to prevent userspace accidentally spamming dmesg.

    Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
    CC: amd-gfx@lists.freedesktop.org
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
    index 083e2b429872..15a2d8f3725d 100644
    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
    @@ -533,6 +533,12 @@ amdgpu_user_framebuffer_create(struct drm_device *dev,
    return ERR_PTR(-ENOENT);
    }

    + /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
    + if (obj->import_attach) {
    + DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
    + return ERR_PTR(-EINVAL);
    + }
    +
    amdgpu_fb = kzalloc(sizeof(*amdgpu_fb), GFP_KERNEL);
    if (amdgpu_fb == NULL) {
    drm_gem_object_unreference_unlocked(obj);
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-04 00:41    [W:4.058 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site