lkml.org 
[lkml]   [2018]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 144/219] md.c:didn't unlock the mddev before return EINVAL in array_size_store
    Date
    From: Zhilong Liu <zlliu@suse.com>

    [ Upstream commit b670883bb9e55ba63a278d83e034faefc01ce2cf ]

    md.c: it needs to release the mddev lock before
    the array_size_store() returns.

    Fixes: ab5a98b132fd ("md-cluster: change array_sectors and update size are not supported")

    Signed-off-by: Zhilong Liu <zlliu@suse.com>
    Reviewed-by: Guoqing Jiang <gqjiang@suse.com>
    Signed-off-by: Shaohua Li <shli@fb.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/md/md.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/md/md.c b/drivers/md/md.c
    index 8ebf1b97e1d2..564da422c179 100644
    --- a/drivers/md/md.c
    +++ b/drivers/md/md.c
    @@ -4826,8 +4826,10 @@ array_size_store(struct mddev *mddev, const char *buf, size_t len)
    return err;

    /* cluster raid doesn't support change array_sectors */
    - if (mddev_is_clustered(mddev))
    + if (mddev_is_clustered(mddev)) {
    + mddev_unlock(mddev);
    return -EINVAL;
    + }

    if (strncmp(buf, "default", 7) == 0) {
    if (mddev->pers)
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-04 00:40    [W:4.086 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site