Messages in this thread | | | From | Francisco Jerez <> | Subject | Re: [kbuild-all] [PATCH] OPTIONAL: cpufreq/intel_pstate: fix debugfs_simple_attr.cocci warnings | Date | Thu, 29 Mar 2018 12:23:10 -0700 |
| |
Fabio Estevam <festevam@gmail.com> writes:
> Hi Julia, > > On Thu, Mar 29, 2018 at 4:12 PM, Julia Lawall <julia.lawall@lip6.fr> wrote: >> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE >> for debugfs files. >> >> Semantic patch information: >> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() >> imposes some significant overhead as compared to >> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Just curious: could you please expand on what "imposes some > significant overhead" means? >
Probably negligible given that this code will only be run once at system boot and then never used again in production systems. But I guess the micro-optimization doesn't hurt either.
> Thanks [unhandled content-type:application/pgp-signature] | |