Messages in this thread | | | Date | Thu, 29 Mar 2018 17:51:16 +0200 | From | LEROY Christophe <> | Subject | Re: [PATCH 11/19] powerpc/powermac: Move pmac_pfunc_base_install prototype to header file |
| |
Mathieu Malaterre <malat@debian.org> a écrit :
> On Fri, Mar 23, 2018 at 1:13 PM, christophe leroy > <christophe.leroy@c-s.fr> wrote: >> >> >> Le 22/03/2018 à 21:19, Mathieu Malaterre a écrit : >>> >>> The pmac_pfunc_base_install prototype was declared in powermac/smp.c since >>> function was used there, move it to pmac_pfunc.h header to be visible in >>> pfunc_base.c. Fix a warning treated as error with W=1: >>> >>> arch/powerpc/platforms/powermac/pfunc_base.c:330:12: error: no previous >>> prototype for ‘pmac_pfunc_base_install’ [-Werror=missing-prototypes] >>> >>> Signed-off-by: Mathieu Malaterre <malat@debian.org> >>> --- >>> arch/powerpc/include/asm/pmac_pfunc.h | 1 + >>> arch/powerpc/platforms/powermac/smp.c | 1 - >>> 2 files changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/powerpc/include/asm/pmac_pfunc.h >>> b/arch/powerpc/include/asm/pmac_pfunc.h >>> index 73bd8f28f2a8..99f7a288789a 100644 >>> --- a/arch/powerpc/include/asm/pmac_pfunc.h >>> +++ b/arch/powerpc/include/asm/pmac_pfunc.h >>> @@ -245,6 +245,7 @@ extern void pmf_put_function(struct pmf_function >>> *func); >>> extern int pmf_call_one(struct pmf_function *func, struct pmf_args >>> *args); >>> +extern int pmac_pfunc_base_install(void); >> >> >> >> extern keyword is not needed > > I understand; but for consistency every single protoypes in this > header file actually use the extern keyword. Is there a guide/best > practice to refer to in this case ?
Consistancy is not a valid reason to continue bad practice. Every single modufication is an opportunity to clean things up
You should run script/checkpatch.pl --strict on all your patches before submitting. And follow as much as possible the linux codying style
Christophe
> >> Christophe >> >>> /* Suspend/resume code called by via-pmu directly for now */ >>> extern void pmac_pfunc_base_suspend(void); >>> diff --git a/arch/powerpc/platforms/powermac/smp.c >>> b/arch/powerpc/platforms/powermac/smp.c >>> index 95275e0e2efa..447da6db450a 100644 >>> --- a/arch/powerpc/platforms/powermac/smp.c >>> +++ b/arch/powerpc/platforms/powermac/smp.c >>> @@ -65,7 +65,6 @@ >>> #endif >>> extern void __secondary_start_pmac_0(void); >>> -extern int pmac_pfunc_base_install(void); >>> static void (*pmac_tb_freeze)(int freeze); >>> static u64 timebase; >>> >> >> --- >> L'absence de virus dans ce courrier électronique a été vérifiée par le >> logiciel antivirus Avast. >> https://www.avast.com/antivirus >>
| |