lkml.org 
[lkml]   [2018]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING
On Thu, Mar 29, 2018 at 04:01:11PM +0200, Peter Zijlstra wrote:
> On Thu, Mar 29, 2018 at 03:47:46PM +0200, Frederic Weisbecker wrote:
> > On Thu, Mar 29, 2018 at 09:16:19AM +0200, Peter Zijlstra wrote:
> > > On Thu, Mar 29, 2018 at 04:27:05AM +0200, Frederic Weisbecker wrote:
> > > > The last user of __ARCH_SET_SOFTIRQ_PENDING has been converted to generic
> > > > per-cpu softirq mask. We can now remove this conditional.
> > >
> > > This seems like half a cleanup; who still has local_softirq_pending()
> > > after this?
> >
> > Only s390 because it uses lowcore to store such cpu data.
>
> Is it worth keeping it there? It seems an aweful shame to keep this
> stuff special cased for just the one arch. At the very least this
> should've mentioned s390 is special and why.

Right, I thought well about moving that special case to s390. I can
do that in v2.

>
> And I don't see s390 people on Cc either.

Oops, forgot to add them.

Thanks.

\
 
 \ /
  Last update: 2018-03-29 16:08    [W:0.060 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site