lkml.org 
[lkml]   [2018]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] virt: vbox: Use __get_free_pages instead of kmalloc for DMA32 memory
On Thu, Mar 29, 2018 at 01:21:15PM +0200, Hans de Goede wrote:
> @@ -87,7 +88,7 @@ void vbg_req_free(void *req, size_t len)
> if (!req)
> return;
>
> - kfree(req);
> + free_pages((unsigned long)req, get_order(PAGE_ALIGN(len)));
> }

Really? This feels wrong to me, why is this driver so special that it
has to use free_pages and the like?

greg k-h

\
 
 \ /
  Last update: 2018-03-29 13:58    [W:0.063 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site