Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH][next] wil6210: fix potential null dereference of ndev before null check | Date | Thu, 29 Mar 2018 07:53:25 +0300 |
| |
merez@codeaurora.org writes:
> On 2018-03-28 20:40, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> The pointer ndev is being dereferenced before it is being null checked, >> hence there is a potential null pointer deference. Fix this by only >> dereferencing ndev after it has been null checked >> >> Detected by CoverityScan, CID#1467010 ("Dereference before null check") >> >> Fixes: e00243fab84b ("wil6210: infrastructure for multiple virtual >> interfaces") >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
[...]
> Reviewed-by: Maya Erez <merez@codeaurora.org>
Maya, as you are the wil6210 maintainer you can actually use Acked-by instead of Reviewed-by. Not that it really matters which one you use, both of them indicate me that you have checked and agree the patch, but wanted to point out this anyway :)
-- Kalle Valo
| |